Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache temporary redirections in the original location (#4459) #4547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kysmith-csg
Copy link
Contributor

Some p2 sites can temporarily redirect to another location. In the case of JFrog Artifactory, these redirection URLs are too long to make as a file path, so the build would fail in this case. For temporary redirects, we save the artifact in the original location instead, since it's likely the redirection might change in the future. Permanent redirects will get their own cache entry as before.

Copy link

github-actions bot commented Dec 20, 2024

Test Results

  603 files  ±0    603 suites  ±0   4h 8m 42s ⏱️ - 5m 35s
  432 tests ±0    423 ✅  - 1   7 💤 ±0  1 ❌ ±0  1 🔥 +1 
1 296 runs  ±0  1 270 ✅  - 3  22 💤 ±0  1 ❌ ±0  3 🔥 +3 

For more details on these failures and errors, see this check.

Results for commit 4955fa7. ± Comparison against base commit feff817.

♻️ This comment has been updated with latest results.

@kysmith-csg
Copy link
Contributor Author

Text not found in log: No repository found at http://localhost:49744/repoB
org.apache.maven.it.VerificationException: Text not found in log: No repository found at http://localhost:49744/repoB
	at org.apache.maven.it.Verifier.verifyTextInLog(Verifier.java:351)
	at org.eclipse.tycho.test.tycho2938.ContentJarTest.redirectToBadLocation(ContentJarTest.java:89)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

We get various other errors, but not this one :(

Running locally I get these three:

  1. Failed to load p2 metadata repository from location http://localhost:57700/repoB
  2. Unable to read repository at http://localhost:57700/repoB
  3. http://localhost:57700/repoB is not a valid repository location

@laeubi
Copy link
Member

laeubi commented Dec 27, 2024

This usually means something is messed up (e.g. redirection do not work anymore, mirrors not working runtime exception occurs and so on).

The best way then is to run

  • mvn clean install -T1C -DskipTests
  • go into tycho-its directory
  • run mvn clean install -Pits -Dtycho.mvnDebug=8000 -Dtest=<fqdn of test>#<failingTest>

this way you can debug one individual test.

Sometimes it also helps to change the test to dump the output to a file, then compare the output of before versus after to see if some log outputs change. One can also enable the debugging for the transport, just set some of these setting in the corresponding test verifier as system properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants